Skip to content

Fixes #701: Add the OVER clause and include it in the Function tokens.#768

Merged
andialbrecht merged 2 commits intoandialbrecht:masterfrom
r33s3n6:master
Apr 13, 2024
Merged

Fixes #701: Add the OVER clause and include it in the Function tokens.#768
andialbrecht merged 2 commits intoandialbrecht:masterfrom
r33s3n6:master

Conversation

@r33s3n6
Copy link
Copy Markdown
Contributor

@r33s3n6 r33s3n6 commented Mar 26, 2024

Resolves #701

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
    (N/A) your changes are documented, if needed

Group tokens such as OVER exist_win or OVER (PARTITION BY...) as the OVER clause before grouping Identifier and Function. Extend tokens of Function to include the OVER clause if it is next to the Parenthesis of function parameters.

@andialbrecht andialbrecht added this to the 0.5.0 milestone Apr 13, 2024
@andialbrecht andialbrecht merged commit e03b74e into andialbrecht:master Apr 13, 2024
@andialbrecht
Copy link
Copy Markdown
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect parsing of expressions in SELECT when "<Window Function> OVER ( ... )" is present

2 participants