Resolve the issue of outdated winpty.pyi#551
Merged
andfoy merged 1 commit intoandfoy:mainfrom Jan 11, 2026
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made to
src/lib.rson July 5, 2025, caused the interface definitions inwinpty.pyito significantly diverge from the actual implementation.This PR addresses the mismatch between
winpty.pyiand the real interface by:selfparameter tocancel_io().read_stderr.lengthparameter from theread()method.encodingparameter from__init__().Additionally, this PR fixes minor type-related issues in
ptyprocess.py:import codecs.b'0011Ignore'to the string'0011Ignore'to prevent a potentialTypeError: encoding without a string argument.