Merged
Conversation
Owner
|
Thanks @XY0797! Could you please rebase this PR in order to fix the merge conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #377, the Python binding corresponding to Rust's
OsStringtype is<class 'str'>.In
winpty/winpty.pyi, the parameters forPTY.spawn, the return values ofPTY.read/read_stderr, and the parameters forPTY.writeare incorrectly annotated asbytes, when they should actually bestr.While these incorrect type annotations were less problematic in the past, modern AI-powered IDEs rely heavily on Python's type system. Erroneous type hints can directly cause AI assistants to generate incorrect code.
To address this, I enabled Pylance's type checking (Standard mode) and manually resolved all type-related errors and warnings.