chore: call cleanup on tmpfile and replace some io.ReadAlls with streams#4629
Merged
willmurphyscode merged 3 commits intomainfrom Feb 17, 2026
Merged
chore: call cleanup on tmpfile and replace some io.ReadAlls with streams#4629willmurphyscode merged 3 commits intomainfrom
willmurphyscode merged 3 commits intomainfrom
Conversation
Previously, Syft could allocate excess memory or tempfile space if there were highly compressed objects in deb archives, or at paths where the kernel changelog was expected by the snap cataloger. Use io.LimitReaders for extracting parts of deb archives, and refactor the snap cataloger's reading of the kernel changelog to use a streaming parsing, eliminating the possibility of excess allocation. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changelog.Debian.gzto be a streaming parser, reducing excess allocations.Type of change
A case could be made for both. Previously, in the file source, if syft encountered an error unarchiving to tmp, it could leak the tempfiles. Fixing that was a bug fix. Also, in the deb and snap catalogers there were some needless io.ReadAll calls that have been replaced with stream parsing.
Checklist
Issue references