Skip to content

fix: further improve go binary classifier, including windows#4593

Merged
kzantow merged 2 commits intoanchore:mainfrom
kzantow-anchore:fix/further-go-binary-search-improvements
Feb 3, 2026
Merged

fix: further improve go binary classifier, including windows#4593
kzantow merged 2 commits intoanchore:mainfrom
kzantow-anchore:fix/further-go-binary-search-improvements

Conversation

@kzantow
Copy link
Contributor

@kzantow kzantow commented Feb 3, 2026

Description

This PR adjusts the go binary classifier in 2 ways:

  • in addition to go binaries, search for go.exe
  • search for VERSION in the same directory as the binary in addition to the parent directory

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@westonsteimel
Copy link
Contributor

I tried this one the docker.io/golang@sha256:ed90906834123a0b67c7b0d004ec930afec5258bfa5435253a666e84bb9d476 test image and it worked, thanks!

@kzantow kzantow merged commit add2629 into anchore:main Feb 3, 2026
10 checks passed
@kzantow kzantow deleted the fix/further-go-binary-search-improvements branch February 3, 2026 15:29
@kzantow kzantow added the bug Something isn't working label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants