Conversation
bff5d5b to
64455d7
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
64455d7 to
38982a7
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the go binary cataloger to be able to decompress LMZA payloads from ELF formatted binaries that have been packed by UPX (a known practice to make the distributed binary size smaller).
This illustrates the main issue we're trying to overcome:
What we want is for syft to be able to still catalog 262 packages from the final UPX packed binary (today we get nothing).
In the future we can expand this to be applied in other areas of syft:
Type of change
Checklist
Issue references
.go.buildinfosections with upx #4411