fix(javascript): remove debug print statement in dependency parser#4412
Merged
wagoodman merged 1 commit intoanchore:mainfrom Dec 10, 2025
Merged
Conversation
Removes an accidental `fmt.Println("error", err)` that was left in
the javascript dependency parser. This causes noisy output to stdout
when parsing npm package-lock.json files that contain dependency
specifiers that aren't valid PURLs.
Signed-off-by: Chris Greeno <chris@fresha.com>
wagoodman
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an accidental
fmt.Println("error", err)that was left in the javascript dependency parser from PR #4304.This causes noisy output to stdout when parsing npm
package-lock.jsonfiles that contain dependency specifiers that aren't valid PURLs (e.g., empty strings or version ranges).Example of the noise
When scanning a repository with npm dependencies:
Fix
Simply remove the debug print statement - the error case is already handled correctly (the dependency is still added via
requires = append(requires, name)on line 34).Testing