Skip to content

Validating download_url for github repositories, and updating if necessary #4390

Merged
wagoodman merged 2 commits intoanchore:mainfrom
kendrickm:feat/update-download-url
Dec 10, 2025
Merged

Validating download_url for github repositories, and updating if necessary #4390
wagoodman merged 2 commits intoanchore:mainfrom
kendrickm:feat/update-download-url

Conversation

@kendrickm
Copy link
Contributor

Description

Checking a URL to be a github respository, and if so converting to an URL that is valid SPDX

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

…b repositories

Signed-off-by: Kendrick <kmartinix@gmail.com>
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful! Would you be able to add a test?

Signed-off-by: Kendrick <kmartinix@gmail.com>
@kendrickm
Copy link
Contributor Author

@kzantow Yep. Just added a test case for this. Thanks!

@wagoodman wagoodman merged commit 7fdb08c into anchore:main Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing to convert npm repository information correctly to SPDX

3 participants