Skip to content

Fixes issue #3346#3474

Closed
Fearkin wants to merge 1 commit intoanchore:mainfrom
Fearkin:main
Closed

Fixes issue #3346#3474
Fearkin wants to merge 1 commit intoanchore:mainfrom
Fearkin:main

Conversation

@Fearkin
Copy link
Copy Markdown
Contributor

@Fearkin Fearkin commented Nov 21, 2024

Description

I have tested this case from the issue mentioned, and it seems to work as intended, but I can't figure out how the tests should be changed (sorry)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@Fearkin Fearkin closed this Nov 21, 2024
@Fearkin Fearkin reopened this Nov 21, 2024
@Fearkin
fixes issue anchore#3346
28801f8 
Signed-off-by: Fearkin <fearjin1@gmail.com>
@popey
Copy link
Copy Markdown
Contributor

popey commented Nov 25, 2024

Thanks for the PR @Fearkin !

I quickly tested it here, and it works as expected.

diff -y mongodb-latest.spdx mongodb-latest-3474.spdx | head -n 30
SPDXVersion: SPDX-2.2                                           SPDXVersion: SPDX-2.2
DataLicense: CC0-1.0                                            DataLicense: CC0-1.0
SPDXID: SPDXRef-DOCUMENT                                        SPDXID: SPDXRef-DOCUMENT
DocumentName: bitnami/mongodb                                   DocumentName: bitnami/mongodb
DocumentNamespace: https://anchore.com/syft/image/bitnami/mon | DocumentNamespace: https://anchore.com/syft/image/bitnami/mon
LicenseListVersion: 3.25                                        LicenseListVersion: 3.25
Creator: Organization: Anchore, Inc                             Creator: Organization: Anchore, Inc
Creator: Tool: syft-1.17.0                                    | Creator: Tool: syft-0.0.0-SNAPSHOT-28801f81
Created: 2024-11-25T08:28:24Z                                 | Created: 2024-11-25T08:36:15Z

##### Unpackaged files                                          ##### Unpackaged files

FileName: /usr/share/perl/5.36.0/App/Prove/State/Result/Test.   FileName: /usr/share/perl/5.36.0/App/Prove/State/Result/Test.
SPDXID: SPDXRef-File-...5.36.0-App-Prove-State-Result-Test.pm   SPDXID: SPDXRef-File-...5.36.0-App-Prove-State-Result-Test.pm
FileType: TEXT                                                  FileType: TEXT
FileChecksum: SHA1: a88b6e865bc11aca43eabb87399375065a75bbf0    FileChecksum: SHA1: a88b6e865bc11aca43eabb87399375065a75bbf0
FileChecksum: SHA256: 61991c84f111bc8f1b21fe32f048a6de2b79e38   FileChecksum: SHA256: 61991c84f111bc8f1b21fe32f048a6de2b79e38
LicenseConcluded: NOASSERTION                                   LicenseConcluded: NOASSERTION
LicenseInfoInFile: NOASSERTION                                  LicenseInfoInFile: NOASSERTION
                                                              > FileCopyrightText: NOASSERTION
FileComment: layerID: sha256:4701132e20c267ad8d758b20ce23347a   FileComment: layerID: sha256:4701132e20c267ad8d758b20ce23347a

FileName: /usr/share/perl/5.36.0/CPAN/Kwalify/distroprefs.dd    FileName: /usr/share/perl/5.36.0/CPAN/Kwalify/distroprefs.dd
SPDXID: SPDXRef-File-...5.36.0-CPAN-Kwalify-distroprefs.dd-aa   SPDXID: SPDXRef-File-...5.36.0-CPAN-Kwalify-distroprefs.dd-aa
FileType: TEXT                                                  FileType: TEXT
FileChecksum: SHA1: 0460d53b1b0b4fb6b1b1ec3218a3182210e0802a    FileChecksum: SHA1: 0460d53b1b0b4fb6b1b1ec3218a3182210e0802a
FileChecksum: SHA256: b88184fdeb35c62b2fc0eed18684e5333a21244   FileChecksum: SHA256: b88184fdeb35c62b2fc0eed18684e5333a21244
LicenseConcluded: NOASSERTION                                   LicenseConcluded: NOASSERTION
LicenseInfoInFile: NOASSERTION                                  LicenseInfoInFile: NOASSERTION
                                                              > FileCopyrightText: NOASSERTION

@spiffcs
Copy link
Copy Markdown
Contributor

spiffcs commented Dec 3, 2024

Pulling this now to fix the tests

@spiffcs spiffcs mentioned this pull request Dec 3, 2024
Merged
4 tasks
@spiffcs
Copy link
Copy Markdown
Contributor

spiffcs commented Dec 3, 2024

@Fearkin I could not push to main on your fork. I checked out a new branch keeping your commits so you get credit for the contribution. New PR can be found here @anchore/tools.

#3495

@spiffcs spiffcs closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid SPDX: missing copyright text

3 participants

@Fearkin @popey @spiffcs