Merged
Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Contributor
|
Saw it pop up in the status - once this merges should we make this required in the repo? |
spiffcs
approved these changes
Jun 4, 2024
Contributor
Author
|
indeed -- but the check wont show up as an option until it's on main |
kzantow
approved these changes
Jun 4, 2024
5 tasks
|
This is a nice idea, thank you. I ended up duplicating this in vitessio/vitess#16052 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an outage noted for the github app we use for checking DCO compliance on each PR and commits on main. In the meantime we'll use a similar python tool to ensure compliance on PRs and consider switching back to the other app once the functionality has been restored.