Skip to content

Add relationships for go binary packages#2912

Merged
spiffcs merged 1 commit intomainfrom
add-go-binary-relationships
May 30, 2024
Merged

Add relationships for go binary packages#2912
spiffcs merged 1 commit intomainfrom
add-go-binary-relationships

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

@wagoodman wagoodman commented May 29, 2024

Partially implements #572

This adds packages for dependencies to go modules found within the buildinfo section of a binary compiled with the go compiler.

A few things to note:

  • This is a flat representation of transitive dependencies. All dependencies directly relate to the go module this is built for. There are no dependency-to-dependency relationships created. This is a limitation of the ecosystem.
  • A relationship is crated for all binaries to the stdlib package.

To make this easier I've updated the cataloger test facilities to take not just full packages (which is difficult to craft for large tests) but instead string representations of packages and use that for assertions. This makes tests that are concerned with wiring and less about correctness in depth to have coverage more easily at the cataloger level. The same was done for relationships.

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman requested a review from a team May 29, 2024 15:37
@wagoodman wagoodman self-assigned this May 29, 2024
@spiffcs spiffcs merged commit f4a69e6 into main May 30, 2024
@spiffcs spiffcs deleted the add-go-binary-relationships branch May 30, 2024 15:37
@wagoodman wagoodman added the enhancement New feature or request label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants