I should note that this drops support for EOL versions of Docker (Docker < v25.0), and only supports API versions v1.44 and up; https://pkg.go.dev/github.com/moby/moby/client@v0.2.1#MinAPIVersion

At least for automatic version negotiation; it does still allow overriding the API version through the DOCKER_API_VERSION env-var (through WithAPIVersionFromEnv; https://pkg.go.dev/github.com/moby/moby/client@v0.2.1#WithAPIVersionFromEnv)

/cc @kzantow @wagoodman this one should be ready for review

I should note that this drops support for EOL versions of Docker (Docker < v25.0), and only supports API versions v1.44 and up; https://pkg.go.dev/github.com/moby/moby/client@v0.2.1#MinAPIVersion

At least for automatic version negotiation; it does still allow overriding the API version through the DOCKER_API_VERSION env-var (through WithAPIVersionFromEnv; https://pkg.go.dev/github.com/moby/moby/client@v0.2.1#WithAPIVersionFromEnv)

Thanks for this, I see the Docker repo now redirects to Moby. Due to the minimum version change, it's going to take some due diligence to understand if we are able to take this change yet, so apologies in advance if it's not merged with a lot of haste 🤞

I see the Docker repo now redirects to Moby.

Yeah, the redirect was in place for quite some Years, but the go code was still using github.com/docker/docker as import path because it was not yet a module (didn't have a go.mod).

The repository is not a multi-module repository with 3 modules;

• github.com/moby/moby/v2 - Module containing the source code for the daemon and dockerd binary itself; this module does not have a stable Go API and is not intended to be used as dependency module (only for building binaries)
• github.com/moby/moby/client - Module containing the API client code. This is the module most will be interested in. It's not v1.0.0 yet, as there's still work to be done, but the old docker/docker/client module will no longer receive updates.
• github.com/moby/moby/api - Module containing API definitions (swagger), and related Go types.

It's going to take some due diligence to understand if we are able to take this change yet, so apologies in advance if it's not merged with a lot of haste 🤞

Sure, no problem! Let me know if help / input is needed 👍

Thanks @thaJeztah for your work on this 🙌 !

Thanks! Oh for this one;

I should note that this drops support for EOL versions of Docker (Docker < v25.0), and only supports API versions v1.44 and up; https://pkg.go.dev/github.com/moby/moby/client@v0.2.1#MinAPIVersion

The upcoming v0.2.3 version of the client module lowers the minimum version to API v1.40 (docker 19.03 and up); there may be some limitations, but probably really edge-case (not impacting code here). It's not released yet, but should be a straight update once it's there 👍