feat(storybook-angular,astro-angular): add Vite 8 OXC config support#2121
Merged
brandonroberts merged 9 commits intoMar 17, 2026
Merged
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
…d from astro-angular config
brandonroberts
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
vite.rolldownVersionconditionals to the two packages that were still using hardcodedesbuildconfig keys, aligning them with the rest of the plugin chain which already handles OXC/esbuild switching.Changes
packages/storybook-angular/src/lib/preset.tsstorybookEsbuildPlugin()tostorybookTransformConfigPlugin()[vite.rolldownVersion ? 'oxc' : 'esbuild']sokeepNames: trueapplies correctly under both esbuild and OXC/Rolldownpackages/astro-angular/src/index.tsgetViteConfiguration()now uses[vite.rolldownVersion ? 'oxc' : 'esbuild']jsx: { development: true }for OXC vsjsxDev: truefor esbuildvitedirectly to detect Rolldown at runtimepackages/astro-angular/package.jsonvitetopeerDependencies(^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0) since the package now imports fromvitedirectlypackages/astro-angular/vite.config.tsesbuild: falseoverridesetupFilesnow that the package no longer needs the old test setup pathtsconfig.base.json@analogjs/vite-plugin-angular/setup-vitestso the new exported setup entry resolves correctly in local development and testsTests
packages/storybook-angular/src/lib/preset.spec.ts— 4 new tests (25 total):should include the transform config pluginshould use esbuild config key when rolldownVersion is not availableshould use oxc config key when rolldownVersion is availableshould only apply during buildpackages/astro-angular/src/index.spec.ts— 3 tests moved to a matched.spec.tsfile:should return astro configurationsshould use esbuild config key when rolldownVersion is not availableshould use oxc config key when rolldownVersion is availableValidation
pnpm nx test storybook-angularpnpm nx test astro-angularContext
All existing
vite.rolldownVersionconditionals in the core plugin chain already handled OXC/esbuild switching.storybook-angularandastro-angularwere the remaining packages still using hardcodedesbuildconfig keys. This completes OXC config coverage across the remaining Analog integration surface while keeping compatibility with the current Vite 5-8 support range.