fix(vite-plugin-angular): use single ? for JIT style resolve suffix#2096
Merged
brandonroberts merged 2 commits intoMar 1, 2026
Merged
Conversation
The resolveId hook uses `??` (double question mark) for the style/template
suffix, producing URLs like `path??inline`. This is incorrect because:
- `?inline` → URL search params: `{ inline: '' }` ✅ (Vite recognizes this)
- `??inline` → URL search params: `{ '?inline': '' }` ❌ (Vite does NOT recognize this)
With `??inline`, Vite's CSS pipeline does not process the file, so SCSS/LESS
files are loaded as raw text without preprocessing in production builds.
Fixes the regression introduced in bcb6da9 (PR analogjs#2024).
Fixes analogjs#2094
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Verifies that: - Style files (angular:jit:style:file;) are resolved with ?inline (single ?) - Template files (angular:jit:template:file;) are resolved with ?raw (single ?) - Neither uses ?? (double question mark) which Vite does not recognize
brandonroberts
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2094
The
resolveIdhook uses??(double question mark) for the style/template URL suffix, producing URLs likepath??inline. Vite does not recognize??inlineas an inline CSS import — it only recognizes?inline(single?).This causes SCSS/LESS files to be loaded as raw text without preprocessing in production builds.
The Fix
One character change:
??→?.Verification
Context
This is a regression from bcb6da9 (PR #2024), which correctly added the style vs template differentiation but accidentally used
??instead of?.