Skip to content

CI:add kernel check#896

Merged
pcercuei merged 1 commit intomasterfrom
staging/add-kernel-check
Sep 6, 2022
Merged

CI:add kernel check#896
pcercuei merged 1 commit intomasterfrom
staging/add-kernel-check

Conversation

@ccraluca
Copy link
Copy Markdown
Contributor

@ccraluca ccraluca commented Sep 2, 2022

Add kernel check. It checks that the structures defined in iio.h are up-to-date with the one defined in the kernel's user-space API headers.
Script will run for each PR, inside Linux-Ubuntu-22.04 job.

Fixes: #891

Signed-off-by: Raluca Chis raluca.chis@analog.com

@ccraluca ccraluca requested a review from pcercuei September 2, 2022 11:44
@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 2, 2022

@rgetz

@ccraluca ccraluca force-pushed the staging/add-kernel-check branch from bbf6f57 to c30a8d2 Compare September 5, 2022 06:56
@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 5, 2022

V2: Codacy error fixed

@pcercuei
Copy link
Copy Markdown
Contributor

pcercuei commented Sep 5, 2022

@ccraluca note that you can add a Fixes: #891 tag to your commit and it should auto-close the issue on github. I like to use it because it allows to keep a trace of what commit fixed what issue.

@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 5, 2022

Oh, ok. I will know for future PR's. I can add now a comment in issue with the link to the commit if help

@pcercuei
Copy link
Copy Markdown
Contributor

pcercuei commented Sep 5, 2022

Can't you add the tag to the commit and force-push? :)

@ccraluca ccraluca linked an issue Sep 5, 2022 that may be closed by this pull request
@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 5, 2022

This is ok?

@pcercuei
Copy link
Copy Markdown
Contributor

pcercuei commented Sep 5, 2022

You didn't add the "Fixes" tag to the commit, did you? I can't see it.

By adding a "fixes" tag I meant just adding a line that says Fixes: #891 at the end of your commit description before the signed-off line.

By the way you could also add a small description to your commit, it does not really say what this "kernel check" is and why it's needed (Basically, it checks that the structures defined in iio.h are up-to-date with the one defined in the kernel's user-space API headers).

@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 6, 2022

Description updated.

@pcercuei
Copy link
Copy Markdown
Contributor

pcercuei commented Sep 6, 2022

@ccraluca this is good, but I meant in the commit, not in the PR's description :)

I don't know what your setup is - but if you use command-line git, you can edit the description of the commit with git commit --amend, then force-push to update this PR with git push -f.

@ccraluca
Copy link
Copy Markdown
Contributor Author

ccraluca commented Sep 6, 2022

Understood now, sorry

It checks that the structures defined in iio.h are up-to-date with the
one defined in the kernel's user-space API headers.

Fixes: #891

Signed-off-by: Raluca Chis <raluca.chis@analog.com>
@ccraluca ccraluca force-pushed the staging/add-kernel-check branch from c30a8d2 to 9f7894c Compare September 6, 2022 10:18
@pcercuei pcercuei merged commit 5b46fa1 into master Sep 6, 2022
@pcercuei pcercuei deleted the staging/add-kernel-check branch September 6, 2022 10:53
@pcercuei
Copy link
Copy Markdown
Contributor

pcercuei commented Sep 6, 2022

@ccraluca No problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lost kernel checks

2 participants