Conversation
When using iio_readdev, stdout is reserved for the data output; so information messages about the context creation must be sent to stderr so that the data stream is not polluted. Fixes #583. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
mhennerich
approved these changes
Apr 1, 2021
Contributor
|
Did we just want to print this while "-v" (verbose)? So in the normal case, people don't need to redirect stderr? |
Contributor
Author
|
I don't think people need to redirect stderr, since they probably redirect stdout already - stderr would just end up in the terminal. |
Contributor
Author
|
I'll merge this now as a quick & easy fix, we can still rework it later with a "verbose" option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using iio_readdev, stdout is reserved for the data output; so
information messages about the context creation must be sent to stderr
so that the data stream is not polluted.
Fixes #583.
Signed-off-by: Paul Cercueil paul@crapouillou.net