XHR#fetchText now returns Response#9567
Merged
jridgewell merged 3 commits intoampproject:masterfrom May 26, 2017
Merged
Conversation
Partial for ampproject#9448.
947a252 to
ff8df67
Compare
cvializ
reviewed
May 26, 2017
| ]).then(() => { | ||
| expect(fetchStub).to.be.calledTwice; | ||
| expect(results[0]).to.equal(TEST_RESPONSE); | ||
| expect(results[1]).to.equal(TEST_RESPONSE); |
Contributor
There was a problem hiding this comment.
why not check that the values match TEST_RESPONSE?
Contributor
Author
There was a problem hiding this comment.
Just a duplicate of the test above.
Contributor
There was a problem hiding this comment.
But I notice you don't call .then(res => res.text()) here, is that intentional? Is it not necessary for a POST? I believe checking the results matching the TEST_RESPONSE a second time for the POST method may catch unexpected behavior.
Contributor
Author
There was a problem hiding this comment.
Processing the response body isn't necessary for the request to happen.
Contributor
Author
|
Approval? 😛 |
cvializ
approved these changes
May 26, 2017
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #9448.