Increase amp-bind integration test timeout#9558
Merged
dreamofabear merged 2 commits intomasterfrom May 25, 2017
Merged
Conversation
rsimha
approved these changes
May 25, 2017
Contributor
rsimha
left a comment
There was a problem hiding this comment.
The default timeout for merges on master is already 10s, and the integration tests are not run for PRs. So if this is targeted at making master green, simply removing the timeout will do the job.
Is the intention to have this change apply to local runs also?
Author
|
Good idea, done. |
Contributor
|
Seems like the integration tests are still timing out on master even after going up to 10s. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were passing previously as unit tests with 10s timeout, so this may fix timeouts on master.