Clean up inconsistent script tags in AMP .md files#9557
Closed
rsimha wants to merge 1 commit intoampproject:masterfrom
rsimha:2017-05-25-CleanUpScriptTags
Closed
Clean up inconsistent script tags in AMP .md files#9557rsimha wants to merge 1 commit intoampproject:masterfrom rsimha:2017-05-25-CleanUpScriptTags
rsimha wants to merge 1 commit intoampproject:masterfrom
rsimha:2017-05-25-CleanUpScriptTags
Conversation
cramforce
requested changes
May 25, 2017
Member
cramforce
left a comment
There was a problem hiding this comment.
As discussed in other PR, this is incorrect. These are docs embedded in HTML. They need to be escaped.
Contributor
Author
|
Continuing discussion about inconsistent tags in this PR. @cramforce, @pbakaus: Sounds good. I'll abandon this change. I wonder though, if it's worth making the braces consistent and escaped (instead of unescaped), since there are currently many instances of opening braces being escaped while their corresponding close braces not being escaped. |
Contributor
|
@rsimha-amp definitely in favor of consistency. To summarize:
|
Contributor
Author
|
@pbakaus, thanks. Will send you a new PR with fixes based on your guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several AMP .md files have inconsistent script tags. Some have escaped "& lt;" tags paired with unescaped > tags.
This PR replaces all escaped script tags in .md files with their unescaped equivalents.
Fixes #9559