Closed
Conversation
cramforce
reviewed
May 19, 2017
Member
cramforce
left a comment
There was a problem hiding this comment.
WOW!
I think this might need to like be its own open source project. Could just give it a package.json and publish to NPM.
@jakearchibald I believe this is relevant to your interest.
| // Maybe this is a last child? Try parents. | ||
| let localDepth = 0; | ||
| for (let n = this.inputPoint_.parentNode; | ||
| n && n != this.input_; |
| // descendant of this node with a sibling. If found, it imports the | ||
| // partial DOM path and the found descendant node into the target DOM. | ||
| // There are limitations of how deep the input DOM can be split and some | ||
| // nodes are not allowed to be split, such as "table" and "ul". |
Member
There was a problem hiding this comment.
Would you mind adding HTML examples to this comment as a sort of timeline for when things happen?
Member
There was a problem hiding this comment.
I guess the tests kind of do this already, but might be nice here.
| let next = null; | ||
| let depth = 0; | ||
| while (!next && | ||
| node.firstChild && |
Contributor
Author
|
/cc @bjalford |
Contributor
Author
|
All, please hold on on this, thanks to @jakearchibald and https://twitter.com/jaffathecake/status/865585897172946944 this can be made quite a bit simpler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Since Shadow DOM streaming is not coming to us, ..."
This exact utility can be reused for streaming friendly iframes as well.