DO NOT SUBMIT - temporary PR for reference #7912
Closed
aghassemi wants to merge 5 commits intoampproject:masterfrom
Closed
DO NOT SUBMIT - temporary PR for reference #7912aghassemi wants to merge 5 commits intoampproject:masterfrom
aghassemi wants to merge 5 commits intoampproject:masterfrom
Conversation
…idebar toggle and breaking it
…idebar toggle and breaking it
…g with sidebar toggle and breaking it" This reverts commit 80b1319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible approach to allowing elements to override global actions. It has a race condition bug where if an element is no built yet, the global action would run instead of the override which although very rare, is not acceptable.
Possible solutions for fixing this race condition bug include:
1- Elements register name of actions they support in v0.js so we don't have to wait for them to load and get built
2- We always wait for element to be built before executing global actions, this will introduce a new delay for all global actions on amp-elements which did not exist before.