Skip to content

Overflow element must have position:relative style #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoytenko merged 1 commit into from
Jan 17, 2017
Merged

Overflow element must have position:relative style #7061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions css/amp.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,9 @@ i-amp-scroll-container.amp-active {
*/
.i-amphtml-element > [overflow] {
cursor: pointer;
/* position:relative is critical to ensure that [overflow] is displayed
above an iframe; z-index is not enough. */
Copy link
Copy Markdown
Contributor

@aghassemi aghassemi Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume problem was z-index alone was not creating a stacking context so maybe comment can be updated to z-index alone is not enough to create a stacking context, element must also be positioned (relatively or absolutely). See https://goo.gl/VzS6TK

position: relative;
z-index: 2;
visibility: hidden;
}
Expand Down