Skip to content

🌐 ♻️ [amp story shopping] Revise rating to be graphic and numerical only#38122

Merged
processprocess merged 7 commits intoampproject:mainfrom
processprocess:ratings
Apr 22, 2022
Merged

🌐 ♻️ [amp story shopping] Revise rating to be graphic and numerical only#38122
processprocess merged 7 commits intoampproject:mainfrom
processprocess:ratings

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

  • Deprecates "reviews" string to remove translation problems due to pluralization and order.
  • Uses filled stars that are locked to half increments

Screen Shot 2022-04-20 at 3 24 26 PM

Screen Shot 2022-04-20 at 3 24 22 PM

Demo

Fixes #38060

@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Apr 20, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.css
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story/1.0/_locales/en.json
src/service/localization/strings.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/en.json
src/service/localization/strings.js

@processprocess processprocess changed the title 🌐 ♻️ [amp story shopping] Revise rating to be graphics and numerical only 🌐 ♻️ [amp story shopping] Revise rating to be graphic and numerical only Apr 20, 2022
@processprocess processprocess merged commit 899d1b4 into ampproject:main Apr 22, 2022
@processprocess processprocess deleted the ratings branch April 22, 2022 17:10
@ampprojectbot
Copy link
Copy Markdown
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[i18n] Do not use concatenation in localizable UI strings

3 participants