Skip to content

✨ amp-story-shopping Allow custom cta-text attribute#38101

Merged
jshamble merged 9 commits intoampproject:mainfrom
jshamble:customcta
Apr 16, 2022
Merged

✨ amp-story-shopping Allow custom cta-text attribute#38101
jshamble merged 9 commits intoampproject:mainfrom
jshamble:customcta

Conversation

@jshamble
Copy link
Copy Markdown
Contributor

Closes #38080

@amp-owners-bot amp-owners-bot bot requested a review from processprocess April 14, 2022 18:07
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Apr 14, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
extensions/amp-story-shopping/amp-story-shopping.md
extensions/amp-story-shopping/validator-amp-story-shopping.protoascii

Hey @ampproject/wg-caching! These files were changed:

extensions/amp-story-shopping/validator-amp-story-shopping.protoascii

@jshamble jshamble requested a review from coreymasanto April 14, 2022 18:09
@jshamble jshamble requested a review from processprocess April 14, 2022 21:26
Copy link
Copy Markdown
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a unit test before merging.

@jshamble jshamble requested a review from antiphoton April 15, 2022 14:50
@jshamble jshamble merged commit 4d09dd1 into ampproject:main Apr 16, 2022
@ampprojectbot
Copy link
Copy Markdown
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amp-story-shopping] Allow for a custom cta

6 participants