Skip to content

♿ 🐛 [Amp story page attachment] Tab-able inline CTA element#37936

Merged
processprocess merged 19 commits intoampproject:mainfrom
processprocess:tabable
Mar 28, 2022
Merged

♿ 🐛 [Amp story page attachment] Tab-able inline CTA element#37936
processprocess merged 19 commits intoampproject:mainfrom
processprocess:tabable

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

@processprocess processprocess commented Mar 22, 2022

  • Makes inline attachments a button element so they are tab-able.
  • Adds classes for inline and outlink CTAs.
  • Removes css targeting by href.
  • Removes dead code.
  • Makes selectors more specific.
  • Updates comments.

Closes #37933

@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Mar 22, 2022

Hey @gmajoulet, @newmuis, @mszylkowski! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.css
extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amp story page attachment] CTA is not tab-able

4 participants