amp-story-shopping: Shopping analytics with conversion tracking#37856
Merged
jshamble merged 50 commits intoampproject:mainfrom Apr 4, 2022
Merged
amp-story-shopping: Shopping analytics with conversion tracking#37856jshamble merged 50 commits intoampproject:mainfrom
jshamble merged 50 commits intoampproject:mainfrom
Conversation
…d triggers to work with reusing the pageattachment trigger
|
Hey @gmajoulet! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Show resolved
Hide resolved
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
Outdated
Show resolved
Hide resolved
Contributor
|
Is this ready to be reviewed? |
…singteh url correctly for conversion tracking
mszylkowski
reviewed
Mar 18, 2022
extensions/amp-story-auto-analytics/0.1/auto-analytics-configs.js
Outdated
Show resolved
Hide resolved
processprocess
requested changes
Mar 31, 2022
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
processprocess
requested changes
Apr 1, 2022
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
processprocess
requested changes
Apr 1, 2022
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
processprocess
requested changes
Apr 1, 2022
processprocess
requested changes
Apr 1, 2022
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
Outdated
Show resolved
Hide resolved
processprocess
approved these changes
Apr 1, 2022
Contributor
processprocess
left a comment
There was a problem hiding this comment.
Small nits. PTAL before submitting.
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
mszylkowski
approved these changes
Apr 4, 2022
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37765
Implements analytics and triggers with conversation tracking in various areas of the story shopping experience.
For the full, detailed list of triggers and events, please see #37765