♻️ Migrate Stories 45..49 to args#37850
Merged
rbeckthomas merged 15 commits intoampproject:mainfrom Mar 15, 2022
Merged
Conversation
13 tasks
|
This pull request introduces 1 alert when merging 1760d9f into b70a0f3 - view on LGTM.com new alerts:
|
kvchari
approved these changes
Mar 14, 2022
Contributor
kvchari
left a comment
There was a problem hiding this comment.
nit: argTypes where the key matches the name property in the value can just be in args (except types that don't get automatically inferred correctly by their defaultValue like type: 'color').
also args should have names that match the name of the component's property/attribute binding, so we don't have to extract and rename the variable (e.g should use data-trackid instead of trackId).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #35923.