🐛 amp-story-shopping removes support for different multi-line border radii#37817
Merged
jshamble merged 6 commits intoampproject:mainfrom Mar 15, 2022
Merged
🐛 amp-story-shopping removes support for different multi-line border radii#37817jshamble merged 6 commits intoampproject:mainfrom
jshamble merged 6 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: |
Contributor
|
I spoke with @hongcatlover and we decided to remove the different border radius on two line text. |
Contributor
|
Nice. Please update the name of the PR to reflect the change. Once the linting check is resolved I think this will be good to go. |
processprocess
approved these changes
Mar 15, 2022
Contributor
processprocess
left a comment
There was a problem hiding this comment.
Awesome! (Also thank you for fixing my typo :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #37808
Some animation CSS keyframes were not calculating the border-radius properly, this PR fixes them.