♻️Migrate Stories 40..44 to args#37729
Merged
rbeckthomas merged 7 commits intoampproject:mainfrom Mar 7, 2022
Merged
Conversation
args
13 tasks
dmanek
approved these changes
Feb 28, 2022
| @@ -72,20 +71,15 @@ export const WithUl = () => { | |||
|
|
|||
| WithUl.storyName = 'with <ul>'; | |||
Contributor
There was a problem hiding this comment.
You can remove this. It's used to describe the story in more detail if needed, but in most cases in our storybook tests, it's the same as the test name.
| side: { | ||
| name: 'side', | ||
| defaultValue: 'left', | ||
| options: ['left', 'right', undefined], |
Contributor
There was a problem hiding this comment.
Does this need to be undefined or can be none?
Contributor
Author
There was a problem hiding this comment.
In this case it needs to be undefined so that the size attr is not set. Setting size='none' does not trigger the correct behavior.
Contributor
There was a problem hiding this comment.
nit: can u add this explanation as a comment so its not confusing why undefined is one of the options.
| const backgroundColor = color('background'); | ||
| const backdropColor = color('backdrop color'); | ||
|
|
||
| export const _default = ({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #35923.