🐛 [amp story page attachment] reopen attachment on refresh#37431
Merged
processprocess merged 6 commits intoampproject:mainfrom Jan 27, 2022
Merged
🐛 [amp story page attachment] reopen attachment on refresh#37431processprocess merged 6 commits intoampproject:mainfrom
processprocess merged 6 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
mszylkowski
reviewed
Jan 20, 2022
mszylkowski
reviewed
Jan 20, 2022
mszylkowski
approved these changes
Jan 20, 2022
Contributor
mszylkowski
left a comment
There was a problem hiding this comment.
Nit: you can chain the promises like so:
whenUpgradedToCustomElement(attachmentEl)
.then(() => attachmentEl.getImpl())
.then(
(attachment) => attachment.open(false /** shouldAnimate */)
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-open the active page's attachment if it was previously open.
Context / Fixes #37430