Skip to content

🚀 [Story performance] Remove rendering service#37345

Merged
mszylkowski merged 9 commits intoampproject:mainfrom
mszylkowski:removeRenderingService
Feb 9, 2022
Merged

🚀 [Story performance] Remove rendering service#37345
mszylkowski merged 9 commits intoampproject:mainfrom
mszylkowski:removeRenderingService

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Jan 11, 2022

We don't use this render-blocking service any more because the CSS overrides this as soon as it's installed.

The code removal is minimal:

dist/v0/amp-story-0.1.mjs: Δ -0.04KB
dist/v0/amp-story-1.0.mjs: Δ -0.04KB
dist/v0/amp-story-0.1.js: Δ -0.06KB
dist/v0/amp-story-1.0.js: Δ -0.06KB
dist/v0.mjs: Δ -0.02KB
dist/v0.js: Δ -0.05KB

@mszylkowski mszylkowski requested a review from gmajoulet February 9, 2022 20:15
@mszylkowski mszylkowski marked this pull request as ready for review February 9, 2022 20:15
@amp-owners-bot amp-owners-bot bot requested a review from jridgewell February 9, 2022 20:15
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Feb 9, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-render-service.js
extensions/amp-story/1.0/amp-story.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants