🐛 [Story attachments] Fix attachment demos#37331
Closed
mszylkowski wants to merge 8 commits intoampproject:mainfrom
Closed
🐛 [Story attachments] Fix attachment demos#37331mszylkowski wants to merge 8 commits intoampproject:mainfrom
mszylkowski wants to merge 8 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
Contributor
|
Nice. I tested this on firebase, the attachment is opening but it's not styled and is throwing errors.
It would also be good to add the import to the other example files using amp-story-page-attachment. |
Contributor
Author
|
Closing in favor of #37335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying a demo, we need to manually import the page attachment into the doc because the
installExtensionForDocfunction generates a url for the extension that doesn't exist on firebase. However, page-attachment assumed that the extension was installed after amp-story, so it fetched the services synchronously.If we fetch the services asynchronously, we can build the page attachment only after amp-story is built.