[amp story shopping] Product Listing Page (PLP)#37318
Merged
processprocess merged 66 commits intoampproject:mainfrom Jan 28, 2022
Merged
[amp story shopping] Product Listing Page (PLP)#37318processprocess merged 66 commits intoampproject:mainfrom
processprocess merged 66 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping.js
Outdated
Show resolved
Hide resolved
coreymasanto
approved these changes
Jan 19, 2022
gmajoulet
reviewed
Jan 19, 2022
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
gmajoulet
reviewed
Jan 25, 2022
Contributor
coreymasanto
left a comment
There was a problem hiding this comment.
Looks good to me, I just left a couple of nits and questions
examples/visual-tests/amp-story/amp-story-shopping-lang-de.html
Outdated
Show resolved
Hide resolved
gmajoulet
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo
Interactive PLP cards will be in a follow up PR.
fixes #36732