Skip to content

🚀 [Story performance] Start localize async (Draft)#37303

Closed
mszylkowski wants to merge 25 commits intoampproject:mainfrom
mszylkowski:startLocalizeAsync
Closed

🚀 [Story performance] Start localize async (Draft)#37303
mszylkowski wants to merge 25 commits intoampproject:mainfrom
mszylkowski:startLocalizeAsync

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Jan 5, 2022 •
edited
Loading

In order to remove all the localization strings from the bundle, we need to fetch async a localization bundle for the document.

dist/v0/amp-story-education-0.1.mjs: Δ +0.15KB
dist/v0/amp-story-education-0.1.js: Δ +0.12KB
dist/v0/amp-story-auto-ads-0.1.mjs: Δ +0.10KB
dist/v0/amp-story-auto-ads-0.1.js: Δ +0.12KB
dist/v0/amp-story-0.1.mjs: Δ -8.48KB
dist/v0/amp-story-1.0.mjs: Δ -8.48KB
dist/v0/amp-story-0.1.js: Δ -8.61KB
dist/v0/amp-story-1.0.js: Δ -8.61KB

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 5, 2022

This pull request fixes 1 alert when merging 3315726 into 4e6b8a5 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 6, 2022

This pull request fixes 1 alert when merging 2e3a0c6 into 5f9e38d - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@mszylkowski mszylkowski self-assigned this Jan 6, 2022
This was referenced Jan 7, 2022
Closed
Open
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 12, 2022

This pull request introduces 1 alert and fixes 1 when merging db6e44f into 4611493 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 12, 2022

This pull request fixes 1 alert when merging 88eb1fa into 036fd40 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 13, 2022

This pull request fixes 1 alert when merging cf69503 into 7557005 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 18, 2022

This pull request fixes 1 alert when merging 974fb82 into 96bebbc - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 19, 2022

This pull request introduces 3 alerts and fixes 1 when merging c70e49b into bcf39f3 - view on LGTM.com

new alerts:

  • 3 for Invocation of non-function

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 19, 2022

This pull request fixes 1 alert when merging 70c453d into bcf39f3 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Mar 9, 2022

This pull request fixes 1 alert when merging 3d7c26f into b70a0f3 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Mar 9, 2022

This pull request fixes 1 alert when merging c989ace into b70a0f3 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@mszylkowski mszylkowski mentioned this pull request Mar 14, 2022
Merged
@mszylkowski mszylkowski closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mszylkowski mszylkowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mszylkowski