Skip to content

🚮 [Story system-layer] Removing unused storyHasAudio state property#37220

Merged
mszylkowski merged 1 commit intoampproject:mainfrom
mszylkowski:removeStoryHasAudio
Dec 15, 2021
Merged

🚮 [Story system-layer] Removing unused storyHasAudio state property#37220
mszylkowski merged 1 commit intoampproject:mainfrom
mszylkowski:removeStoryHasAudio

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Dec 14, 2021

Closes #37163

@mszylkowski mszylkowski marked this pull request as ready for review December 14, 2021 21:47
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Dec 14, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js
extensions/amp-story/1.0/amp-story-system-layer.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story-store-service.js

@mszylkowski mszylkowski merged commit 0201b68 into ampproject:main Dec 15, 2021
@mszylkowski mszylkowski deleted the removeStoryHasAudio branch December 15, 2021 17:08
@mszylkowski mszylkowski mentioned this pull request Jan 7, 2022
Merged
@processprocess processprocess mentioned this pull request Mar 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

No one assigned

Labels

PR use: In Beta / Experimental PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Story system-layer] Remove story has audio flag

4 participants

@mszylkowski @gmajoulet @processprocess @ampprojectbot