Skip to content

🐛 Don't render CTA button when there are no shopping tags#37114

Merged
jshamble merged 11 commits intoampproject:mainfrom
jshamble:renderZero
Dec 14, 2021
Merged

🐛 Don't render CTA button when there are no shopping tags#37114
jshamble merged 11 commits intoampproject:mainfrom
jshamble:renderZero

Conversation

@jshamble
Copy link
Copy Markdown
Contributor

@jshamble jshamble commented Dec 5, 2021

Doesn't render the cta button when there are no shopping tag elements.

closes #37004

Before After
Screen Shot 2021-12-13 at 4 49 20 PM Screen Shot 2021-12-13 at 4 53 53 PM

@jshamble jshamble requested review from coreymasanto and processprocess and removed request for coreymasanto December 5, 2021 05:57
@amp-owners-bot amp-owners-bot bot requested a review from gmajoulet December 5, 2021 05:57
@jshamble jshamble requested review from coreymasanto and removed request for gmajoulet December 5, 2021 05:57
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Dec 5, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js

@jshamble jshamble requested a review from coreymasanto December 7, 2021 18:55
Copy link
Copy Markdown
Contributor

@coreymasanto coreymasanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a before image & after image to the description?

@jshamble jshamble requested review from gmajoulet and removed request for processprocess December 14, 2021 00:59
@jshamble jshamble dismissed processprocess’s stale review December 14, 2021 23:35

processprocess is OOO so Gabriel will be reviewing until he gets back.

@jshamble jshamble merged commit d2a7450 into ampproject:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amp story shopping] Do not render CTA if no product tags are on page

5 participants