✨amp-story-shopping Set active product in store service for product tag.#37103
Merged
processprocess merged 22 commits intoampproject:mainfrom Dec 22, 2021
Merged
✨amp-story-shopping Set active product in store service for product tag.#37103processprocess merged 22 commits intoampproject:mainfrom
processprocess merged 22 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
Contributor
processprocess
left a comment
There was a problem hiding this comment.
Nice work!
I left some comments on how we can remove the storeService.get and how it's beneficial to set activeProduct to the entire product data.
Don't forget to update the typeDef to include activeProduct!
Also now that I'm thinking about it, it might make more sense to name it activeProductData.
processprocess
requested changes
Dec 7, 2021
coreymasanto
reviewed
Dec 7, 2021
processprocess
previously requested changes
Dec 8, 2021
gmajoulet
reviewed
Dec 9, 2021
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
Outdated
Show resolved
Hide resolved
coreymasanto
reviewed
Dec 9, 2021
gmajoulet
approved these changes
Dec 14, 2021
processprocess is OOO and gmajoulet will be taking his place until he gets back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to set the active product in the store service when a shopping tag is clicked.
closes #37013