🏗 Lint uses of core/dom/jsx#36881
Merged
alanorozco merged 10 commits intoampproject:mainfrom Nov 11, 2021
Merged
Conversation
|
Hey @erwinmombay! These files were changed: Hey @jridgewell! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: |
jridgewell
reviewed
Nov 11, 2021
| isCoreDomJsx = false; | ||
| }, | ||
| ImportNamespaceSpecifier(node) { | ||
| if (node.parent.source.value.endsWith('core/dom/jsx')) { |
Member
Author
There was a problem hiding this comment.
I'll handle that right after this so I can start off with a clean preact rule.
Comment on lines
+51
to
+52
| node.value.expression?.type === 'Literal' || | ||
| node.value.expression?.type === 'TemplateLiteral' |
Contributor
There was a problem hiding this comment.
Is the expression?.type optional chain because of JSX nodes as direct values of attributes? I'm surprised you caught that.
Member
Author
There was a problem hiding this comment.
Wow, I did not know this was possible! I used an optional chain out of habit only.
jridgewell
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36679
This handles all caveats mentioned except mapped attribute names, which are handled by
local/preact-preferred-propsAlso transfers relevant rules from
local/preactintolocal/core-dom-jsx.