Skip to content

🖍 [Page Attachments] Add the 'Read more' string for translation#36775

Merged
coreymasanto merged 3 commits intoampproject:mainfrom
coreymasanto:read-more
Nov 5, 2021
Merged

🖍 [Page Attachments] Add the 'Read more' string for translation#36775
coreymasanto merged 3 commits intoampproject:mainfrom
coreymasanto:read-more

Conversation

@coreymasanto
Copy link
Copy Markdown
Contributor

@coreymasanto coreymasanto commented Nov 4, 2021

As discussed in #36724, we are updating the default CTA for page attachments from "Swipe up" to "Read more". This PR adds this new "Read more" string in the appropriate places to be translated.

@coreymasanto coreymasanto self-assigned this Nov 4, 2021
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Nov 4, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/en.json
src/service/localization/strings.js

@coreymasanto coreymasanto changed the title 🖍 Add the 'Read more' string for translation and prefer it as the fallback CTA for page attachments 🖍 [Page Attachments] Add the 'Read more' string for translation Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants