🚀 [Story performance] Remove media query matcher#36747
Merged
mszylkowski merged 4 commits intoampproject:mainfrom Nov 5, 2021
Merged
🚀 [Story performance] Remove media query matcher#36747mszylkowski merged 4 commits intoampproject:mainfrom
mszylkowski merged 4 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Nov 3, 2021
|
|
||
| this.initializePromise_ = new Promise((resolve) => { | ||
| this.matcher_ = this.win_.document.createElement('iframe'); | ||
| this.matcher_.classList.add('i-amphtml-story-media-query-matcher'); |
Contributor
There was a problem hiding this comment.
This CSS can be removed too
gmajoulet
reviewed
Nov 3, 2021
| * @return {!AmpStoryMediaQueryService} | ||
| */ | ||
| export const getMediaQueryService = (win) => { | ||
| let service = Services.storyMediaQueryService(win); |
Contributor
There was a problem hiding this comment.
This can be removed too from #service
gmajoulet
approved these changes
Nov 3, 2021
Contributor
Author
|
@jridgewell for service/index.html |
jridgewell
approved these changes
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36695
We don't use the media query matcher, so we can remove it from the bundle