✨amp-story-shopping scaffold : contains shopping config, attachment, and tag.#36462
Merged
jshamble merged 66 commits intoampproject:mainfrom Oct 29, 2021
Merged
✨amp-story-shopping scaffold : contains shopping config, attachment, and tag.#36462jshamble merged 66 commits intoampproject:mainfrom
jshamble merged 66 commits intoampproject:mainfrom
Conversation
…es for amp story shopping tag, attachment, and config components
|
Hey @ampproject/wg-caching! These files were changed: |
honeybadgerdontcare
requested changes
Oct 22, 2021
extensions/amp-story-shopping/0.1/test/validator-amp-story-shopping.html
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/validator-amp-story-shopping.protoascii
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/validator-amp-story-shopping.protoascii
Outdated
Show resolved
Hide resolved
Contributor
|
cc @honeybadgerdontcare or @Gregable can you remind us how we configure validation rules to accept the |
extensions/amp-story-shopping/0.1/test/validator-amp-story-shopping.html
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/validator-amp-story-shopping.protoascii
Outdated
Show resolved
Hide resolved
coreymasanto
approved these changes
Oct 27, 2021
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
gmajoulet
approved these changes
Oct 28, 2021
honeybadgerdontcare
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the boilerplate code for the amp-story-shopping component, as well as setups up the unit tests and css for the boilerplate's scaffold components (config, attachment, and tag).
Fixes #36429