🚀 Sort video sources by tuples of (codec, bitrate) and append codec information to the video's type attribute#36224
Merged
coreymasanto merged 19 commits intoampproject:mainfrom Oct 7, 2021
Conversation
…y descending bitrate value
…lues in the comparator function
…he .foreach were being ignored, and fixing it would result in less readable code than a simple for loop
Contributor
Author
|
Note that the |
gmajoulet
reviewed
Sep 30, 2021
…video sources; split added test into 2 (validation of bitrate sort and validation of codec sort); update test video json to include codec information
gmajoulet
reviewed
Oct 6, 2021
gmajoulet
approved these changes
Oct 6, 2021
gmajoulet
approved these changes
Oct 6, 2021
jridgewell
reviewed
Oct 7, 2021
…scribe the sorting behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video sources are currently sorted only by bitrate, and the source that contains the highest bitrate is prioritized. Because we want to prioritize the VP9 codec, this PR uses
codecvalues as the primary means of sorting all potential sources for each video. As a result,bitrate_kbpswill be used only as a secondary factor in the sort.Fixes #36228