BentoStreamGallery: Use toChildArray to get the length#36154
Merged
caroqliu merged 2 commits intoampproject:mainfrom Sep 24, 2021
Merged
BentoStreamGallery: Use toChildArray to get the length#36154caroqliu merged 2 commits intoampproject:mainfrom
BentoStreamGallery: Use toChildArray to get the length#36154caroqliu merged 2 commits intoampproject:mainfrom
Conversation
10 tasks
dmanek
reviewed
Sep 23, 2021
| const carouselRef = useRef(null); | ||
| const [visibleCount, setVisibleCount] = useState(DEFAULT_VISIBLE_COUNT); | ||
|
|
||
| const length = useMemo(() => toChildArray(children), [children]); |
Contributor
There was a problem hiding this comment.
toChildArray(children).lengthright?- nit:
useMemomight be an overkill here. Typically its used for expensive calculations - calculating length isn't one of them 🙂
Contributor
Author
There was a problem hiding this comment.
Good catch on both accounts, thanks.
dmanek
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
toChildArrayto get thechildren.length, partial for #35678