Reenable EsbuildCompilation on EXP_C#36105
Merged
samouri merged 5 commits intoampproject:mainfrom Sep 23, 2021
Merged
Conversation
|
Hey @danielrozenberg! These files were changed: |
jridgewell
approved these changes
Sep 21, 2021
rsimha
reviewed
Sep 21, 2021
76b3762 to
de5c258
Compare
Member
Author
|
@rsimha: PTAL |
rsimha
approved these changes
Sep 22, 2021
Contributor
rsimha
left a comment
There was a problem hiding this comment.
LGTM after a minor readability fix.
787e2ec to
a45dc36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
See #35816 for a PR that forces
esbuildto be true and has all of CI green. Adds in one important fix for EXP_C, and then two fixes that only matter when it is the primary bundler:(important): accept either unminified or minified name for. Instead I passgetAmpConfigForFile. The distinction wasn't useful and forced us to pass in the minified name for minified builds (srcFilenameis more ergonomic)destFilenametest:truecheck should also allow!0since that is the minified version oftrueconfidence checks