Broadbandy AMP Integration #36010
Merged
powerivq merged 135 commits intoampproject:mainfrom Sep 16, 2021
Merged
Conversation
|
|
|
Hey @rsimha! These files were changed: Hey @erwinmombay! These files were changed: Hey @jridgewell! These files were changed: Hey @alanorozco! These files were changed: Hey @rcebulko! These files were changed: Hey @estherkim! These files were changed: Hey @danielrozenberg! These files were changed: Hey @jeffkaufman! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: Hey @processprocess! These files were changed: Hey @westonruter, @ediamin! These files were changed: Hey @ampproject/wg-performance! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
* update compilerOptions.paths to handle barrel files (index.js) in VSCode * update includes/excludes allowlist/blocklist src files
* Bento Selector Option: Give props via JSX * Remove extraneous event handlers
* applyAmpConfig: also update sourcemaps * no stone unturned: AMP_CONFIG should be part of the wrapper * update comments * update comment + fix bug * another bugfix * allow newline between ; and AMP_CONFIG * retain logs for dist|build * smol clean * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * target --> filename Co-authored-by: Raghu Simha <rsimha@amp.dev>
…ect#35317) * Since we are not using the data, lets remove it * Remove all isIE checks and polyfills only used by IE * Remove URL changes * Integration tests were looking for IE specifics * remove transparent img, and ie tests * Skip all tests on IE, this functionality will be removed by the infra team following success * try using user agent directy in test configuration * Fix * Feedback on describe tests not needing configuration now * Remove unused files again * Fix build before main is repaired
* Merged the VerizonMedia ad component into the yahoo component * Fixed documentation formatting issues.
* Catch for promise. * Update comment. * Send e.
…ject#35786) * Add position to attachment-content wrapper. * whitespace
* Wrap all play calls in catch handler * Introduce playIgnoringError * Fix type * Fix undefined return case
…ent unintentionally (ampproject#35779)
* add policy attributes * add owners * update files for Owners. * Revert file * added GAM implementation * removed policy attribute * removed policy attribute description * changed attribute name and corrected indentation * indentation corrected * new line added at last
This is to prevent new stable releases of Chrome from causing test failures. Eg, the Chrome 93 release caused several tests failures that made `main` red until the tests were skipped. This delayed a cherry-pick we're working on, since the new release (on on top of old code) also picked up Chrome 93. This should be updated regularly, hopefully with a chance to test Chrome releases during the Beta period so we can proactively fix issues. Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>
* Add try catch * Changed PR number to match PR
Contributor
Author
|
HI, i see the we are still missing the approval, anything we can do from our side? |
calebcordry
reviewed
Sep 13, 2021
Member
calebcordry
left a comment
There was a problem hiding this comment.
Thanks for contributing! just one nit.
powerivq
requested changes
Sep 13, 2021
powerivq
requested changes
Sep 14, 2021
Contributor
powerivq
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
We'd like to integrate our Ad-Server with AMP. We've contributed to AMP as per documentation. Please check & approve.
Thanks in advance!
Tijl Verbert