Skip to content

Revert "cl/394490119 Fix a bug where the CSS parser was not correctly accounting for the possibility of calc() in the media expression."#35939

Closed
Gregable wants to merge 1 commit intomainfrom
revert-35937-validator-rollup
Closed

Revert "cl/394490119 Fix a bug where the CSS parser was not correctly accounting for the possibility of calc() in the media expression."#35939
Gregable wants to merge 1 commit intomainfrom
revert-35937-validator-rollup

Conversation

@Gregable
Copy link
Copy Markdown
Member

@Gregable Gregable commented Sep 3, 2021

Reverts #35937

@Gregable
Revert "cl/394490119 Fix a bug where the CSS parser was not correctly…
d388957 
… accounting for the possibility of calc() in the media expression. (#35937)"

This reverts commit b226f9d.
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Sep 3, 2021 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/js/engine/parse-css.js
validator/js/engine/parse-css_test.js
validator/testdata/feature_tests/media_expression_calc.html
validator/testdata/feature_tests/media_expression_calc.out

@Gregable Gregable mentioned this pull request Sep 3, 2021
Merged
honeybadgerdontcare
honeybadgerdontcare approved these changes Sep 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proactively approving in case this needs to be merged

@Gregable Gregable closed this Sep 3, 2021
@rsimha rsimha deleted the revert-35937-validator-rollup branch October 19, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gregable @honeybadgerdontcare