🏗 Fix unminified build on Windows#35713
Merged
rsimha merged 1 commit intoampproject:mainfrom Aug 18, 2021
rsimha:2021-08-17-WindowsBuild
Merged
🏗 Fix unminified build on Windows#35713rsimha merged 1 commit intoampproject:mainfrom rsimha:2021-08-17-WindowsBuild
rsimha merged 1 commit intoampproject:mainfrom
rsimha:2021-08-17-WindowsBuild
Conversation
samouri
reviewed
Aug 18, 2021
samouri
reviewed
Aug 18, 2021
samouri
approved these changes
Aug 18, 2021
Contributor
Author
|
Can confirm this did the trick. See recent builds.
|
This was referenced Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Highlights:
amp buildon Windows (the path being passed tocompileJison()was incorrectly formatted on Windows)compileJison()by eliminating ~200 parallel + synchronous + unnecessarymkdirSyncoperationsPassing logs: here
Addresses #35630 (comment)