Skip to content

lint: allow rest,spread, and array destructure#35699

Merged
samouri merged 1 commit intoampproject:mainfrom
samouri:nono-rest-till-brooklyn
Aug 19, 2021
Merged

lint: allow rest,spread, and array destructure#35699
samouri merged 1 commit intoampproject:mainfrom
samouri:nono-rest-till-brooklyn

Conversation

@samouri
Copy link
Copy Markdown
Member

@samouri samouri commented Aug 17, 2021 •
edited
Loading

Partial for #35694

cc @ampproject/wg-performance

@samouri samouri self-assigned this Aug 17, 2021
@samouri samouri changed the title lint: allow rest,spread, array destructure lint: allow rest,spread, and array destructure Aug 17, 2021
@samouri samouri mentioned this pull request Aug 17, 2021
Open
5 tasks
@samouri samouri force-pushed the nono-rest-till-brooklyn branch from 62e009b to 838b4bc Compare August 17, 2021 15:16
@samouri samouri marked this pull request as ready for review August 17, 2021 15:30
@amp-owners-bot amp-owners-bot bot requested a review from rileyajones August 17, 2021 15:30
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Aug 17, 2021

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/eslint-rules/no-array-destructuring.js
build-system/eslint-rules/no-rest.js
build-system/eslint-rules/no-spread.js

@samouri samouri requested review from erwinmombay, jridgewell and rcebulko and removed request for rcebulko and rileyajones August 17, 2021 15:30
@samouri samouri force-pushed the nono-rest-till-brooklyn branch from 838b4bc to c002fcc Compare August 18, 2021 18:30
@samouri
Copy link
Copy Markdown
Member Author

samouri commented Aug 18, 2021

@jridgewell 🏓

@samouri samouri merged commit 1b6e1c3 into ampproject:main Aug 19, 2021
@samouri samouri deleted the nono-rest-till-brooklyn branch August 19, 2021 03:30
@samouri samouri mentioned this pull request Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jridgewell jridgewell jridgewell approved these changes

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

+1 more reviewer

@rcebulko rcebulko rcebulko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samouri samouri

Labels

PR use: In Beta / Experimental PR use: In LTS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samouri @jridgewell @rcebulko @ampprojectbot