added story ad badge fix for safari#35429
Merged
powerivq merged 7 commits intoampproject:mainfrom Jul 30, 2021
Merged
Conversation
|
Hey @erwinmombay, @jridgewell! These files were changed: |
jridgewell
reviewed
Jul 28, 2021
powerivq
requested changes
Jul 28, 2021
jridgewell
requested changes
Jul 28, 2021
jridgewell
reviewed
Jul 29, 2021
jridgewell
approved these changes
Jul 29, 2021
powerivq
approved these changes
Jul 30, 2021
Member
|
I think we accidentally changed the UI a bit here. OLD
NEW
DESIGN SPEC Let's get a fix in ASAP. Also we should write a test to prevent similar issues in the future. |
Contributor
|
Super curious: why does loading the SVG via JS instead of CSS fix this? |
Contributor
|
The CSS background is being rasterized once to a PNG (internally in the browser), and then being resized. Creating true SVG nodes allows the browser to scale the SVG infinitely, making the text appear much crisper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the story ad badge for iOS devices by using the static html template in order to load the svg via javascript instead of css. Before this fix, it was pixelated / blurry (on iOS device such as the iphone X), now it is sharp and clear. Removed some unnecessary css rules.
🐛 Bug fix
🖍 CSS / Styling