Skip to content

✨ [Amp story player] [panel player] Launch panel player#35423

Merged
processprocess merged 9 commits intoampproject:mainfrom
processprocess:player-buttons
Sep 23, 2021
Merged

✨ [Amp story player] [panel player] Launch panel player#35423
processprocess merged 9 commits intoampproject:mainfrom
processprocess:player-buttons

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

@processprocess processprocess commented Jul 27, 2021

  • removes experiment flag to launch panel player
  • hides buttons when not in panel mode
  • removes desktop from variables

Closes #34765

@processprocess processprocess requested a review from gmajoulet July 27, 2021 20:42
@processprocess processprocess self-assigned this Jul 27, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [Desktop panels player] Launch panel player ✨ [Amp story player] [panels player] Launch panel player Jul 28, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [panels player] Launch panel player ✨ [Amp story player] [panel player] Launch panel player Jul 28, 2021
@gmajoulet
Copy link
Copy Markdown
Contributor

Is there anything I can help with to merge this?

@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story-player/0.1/test/test-e2e/test-amp-story-player-prerender.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

amp-story-desktop-one-panel Integrate player into desktop one panel experience

3 participants